-
Notifications
You must be signed in to change notification settings - Fork 245
chore(evergreen): use macos 15 DEVPROD-18250 #7531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| - name: unit-tests-macos | ||
| display_name: Unit Tests MacOS | ||
| run_on: macos-14-arm64 | ||
| run_on: macos-15-arm64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specifically this will probably not work: just noticed that while we got gui hosts, we didn't really get non-gui ones and so there's only one there and its quarantined 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we can get away with a single fleet (with desktop and docker present); would you mind using "macos-15-arm64-gui"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Theoretically it's totally possible! Our usual concern here is that there's not a lot of these gui hosts, so we're trying to only use them for tasks where gui session is a requirement. I do think though that we might want to reshuffle things a bit here anyway and work around that by:
- Only running units for macos on main, not on PRs. Then overuse of those hosts is less of a concern
- For non-gui variant here, maybe keep them running on macos-14 if provisioning macos-15 is a hassle. For unit tests I don't think we really need to be that strict here on what we're testing
Also just want to mention that e2e tests seem to be running just fine, so from that perspective new machines definitely work as expected for us!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leafnunes Is your suggestion that devprod will merge the fleets and provide a single distro id for all those macOS hosts, so the total # of hosts available will be fairly large?
That actually sounds like a decent idea, I think we just assumed that it would be additional work for DevProd to provision and maintain extra GUI hosts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@addaleax Yes; while it does require a manual step to enable, once a base image is made it's possible to build from it and deploy them in an automated fashion. Until we don't need guis at all, we might as well consolidate so every mac host provides the same services.
We can revisit this decision if breaking them out makes better sense from a scheduling perspective (i.e. if gui tests that run for a long time end up blocking shorter tasks for longer than necessary)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not opposed to that idea at all, but yeah, would be nice to get a few more of these macos-15-gui hosts. I think for now we might be okay with switching all variants of macos unit tests to these gui hosts and only running them on main, not on patches. If we notice that this starts to slow us down, we can reconsider
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed the change to switch all macos units to gui and disable them on patches. Tried them manually in this patch
ba5a2f1 to
f151c8d
Compare
Checking if those are set up correctly