DOCSP-45846-update-toggle-connections-compass #727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-compass ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jmd-mongo
reviewed
Mar 11, 2025
There was a problem hiding this comment.
Thank you for these updates, @amalhotra-mdb! Overall, this LGTM from a copy standpoint.
I'm curious if the filter-connections.png screenshot could highlight the UI element. Maybe just a colored box around it, like in connection-sidebar.png. What do you think?
Thanks!
Joe
|
Great idea @jmd-mongo, I went ahead and added the red boxes to both screenshots! Thanks for your review, could you take a second look to make sure it looks ok? Thank you! |
lerouxb
approved these changes
Mar 13, 2025
amalhotra-mdb
requested review from
jmd-mongo
and removed request for
jmd-mongo
jmd-mongo
approved these changes
Mar 14, 2025
There was a problem hiding this comment.
Thanks for these additional updates, @amalhotra-mdb! This one LGTM at this point.
Thanks,
Joe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
Update screenshots and add section to Compass "connection" page to demonstrate how to filter connections list for only active connections.
STAGING
https://deploy-preview-727--docs-compass.netlify.app/connect/connections/
JIRA
https://jira.mongodb.org/browse/DOCSP-45846
BUILD LOG
Self-Review Checklist
External Review Requirements
What's expected of an external reviewer?