v1.60.0 #134
v1.60.0 #134
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a major restructure of the Kingfisher CLI by replacing legacy top-level provider commands with provider-specific subcommands under kingfisher scan. Key changes include removing Bitbucket authentication flags in favor of environment variables, adding deprecation warnings for legacy flags, and consolidating repository enumeration under --list-only switches.
- Replaced top-level provider commands with
kingfisher scan <provider>subcommands - Removed Bitbucket authentication flags in favor of
KF_BITBUCKET_*environment variables - Added
--list-onlyflag to provider subcommands for repository enumeration
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
tests/cli_subcommands.rs
Outdated
| .args(["scan", "bitbucket", "--help"]) | ||
| .assert() | ||
| .stdout(contains("kingfisher scan bitbucket [OPTIONS]")); | ||
| .stdout(is_match(r"kingfisher(\\.exe)? scan bitbucket \[OPTIONS\]").unwrap()); |
There was a problem hiding this comment.
The regex pattern should use raw string literal syntax consistently. The double backslash \\. is unnecessary in a raw string and should be \. instead. The pattern should be r"kingfisher(\.exe)? scan bitbucket \[OPTIONS\]".
| .stdout(is_match(r"kingfisher(\\.exe)? scan bitbucket \[OPTIONS\]").unwrap()); | |
| .stdout(is_match(r"kingfisher(\.exe)? scan bitbucket \[OPTIONS\]").unwrap()); |
[v1.60.0]
--bitbucket-username,--bitbucket-token, and--bitbucket-oauth-tokenflags in favour ofKF_BITBUCKET_*environment variables when authenticating to Bitbucket.kingfisher scansubcommands (for examplekingfisher scan github …) that translate into the legacy flags under the hood. The new layout keeps backwards compatibility while removing the wall of provider options fromkingfisher scan --help.--github-user,--gitlab-group,--bitbucket-workspace,--s3-bucket) still work but now emit a deprecation warning to encourage migration to the newkingfisher scan <provider>flow.kingfisher scan /path/to/dirflow for local filesystem / local git repo scans while adding a--list-onlyswitch to each provider subcommand so repository enumeration no longer requires the standalonegithub repos,gitlab repos, etc. commands.kingfisher github,kingfisher gitlab,kingfisher gitea,kingfisher bitbucket,kingfisher azure,kingfisher huggingface) now that enumeration lives underkingfisher scan <provider> --list-only.