v1.61.0 #137
Merged
v1.61.0 #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pening Git repositories and only disable it for diff-based scans. - Created Linux and Windows specific installer script - Updated diff-focused scanning so --branch-root-commit can be provided alongside --branch, letting you diff from a chosen commit while targeting a specific branch tip (still defaulting back to the --branch ref when the commit is omitted).
…pening Git repositories and only disable it for diff-based scans. - Created Linux and Windows specific installer script - Updated diff-focused scanning so --branch-root-commit can be provided alongside --branch, letting you diff from a chosen commit while targeting a specific branch tip (still defaulting back to the --branch ref when the commit is omitted).
…pening Git repositories and only disable it for diff-based scans. - Created Linux and Windows specific installer script - Updated diff-focused scanning so --branch-root-commit can be provided alongside --branch, letting you diff from a chosen commit while targeting a specific branch tip (still defaulting back to the --branch ref when the commit is omitted).
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request implements version 1.61.0 with several key improvements to Git repository scanning functionality and deployment infrastructure. The main focus is on enhancing branch-focused scanning capabilities and providing better installation options for end users.
- Fixed local filesystem scans to preserve Git repository access while optimizing diff-based scanning behavior
- Added new CLI flags
--branch-rootand--branch-root-committo enable inclusive commit-based scanning with flexible root specification - Created platform-specific installer scripts for Linux/macOS and Windows to simplify deployment
Reviewed Changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/smoke_branch.rs | Added comprehensive test coverage for new branch-root scanning functionality |
| tests/smoke_baseline.rs | Enhanced baseline tests with Git history isolation and stability verification |
| src/scanner/enumerate.rs | Implemented branch-root commit logic and updated Git repository opening behavior |
| src/cli/commands/inputs.rs | Added CLI argument definitions for --branch-root and --branch-root-commit flags |
| src/baseline.rs | Refactored baseline filtering to use fingerprints and added comprehensive unit tests |
| scripts/install-kingfisher.sh | New cross-platform installer script for Unix-like systems |
| scripts/install-kingfisher.ps1 | New PowerShell installer script for Windows |
| data/rules/*.yml | Updated detection rules for GitLab, Vercel, and Azure Storage services |
| README.md | Updated installation instructions and documented new branch scanning capabilities |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+138
to
+142
| /// | ||
| /// | ||
| /// | ||
| /// | ||
| /// |
There was a problem hiding this comment.
These empty comment lines should be removed or replaced with meaningful documentation describing the function's purpose.
Suggested change
| /// | |
| /// | |
| /// | |
| /// | |
| /// |
Comment on lines
+964
to
+986
| // #[cfg(test)] | ||
| // mod tests { | ||
| // use std::sync::Arc; | ||
|
|
||
| // use anyhow::Result; | ||
| // use crossbeam_skiplist::SkipMap; | ||
| // use http::StatusCode; | ||
| // use rustc_hash::FxHashMap; | ||
| // use smallvec::smallvec; | ||
|
|
||
| // use crate::{ | ||
| // blob::BlobId, | ||
| // liquid_filters::register_all, | ||
| // location::OffsetSpan, | ||
| // matcher::{OwnedBlobMatch, SerializableCapture, SerializableCaptures}, | ||
| // rules::{ | ||
| // rule::{Confidence, Rule}, | ||
| // Rules, | ||
| // }, | ||
| // util::intern, | ||
| // validation::{validate_single_match, Cache}, | ||
| // }; | ||
| // #[tokio::test] |
There was a problem hiding this comment.
Consider removing this large block of commented-out test code instead of leaving it commented. If the test is needed, it should be active; otherwise it adds unnecessary clutter.
Suggested change
| // #[cfg(test)] | |
| // mod tests { | |
| // use std::sync::Arc; | |
| // use anyhow::Result; | |
| // use crossbeam_skiplist::SkipMap; | |
| // use http::StatusCode; | |
| // use rustc_hash::FxHashMap; | |
| // use smallvec::smallvec; | |
| // use crate::{ | |
| // blob::BlobId, | |
| // liquid_filters::register_all, | |
| // location::OffsetSpan, | |
| // matcher::{OwnedBlobMatch, SerializableCapture, SerializableCaptures}, | |
| // rules::{ | |
| // rule::{Confidence, Rule}, | |
| // Rules, | |
| // }, | |
| // util::intern, | |
| // validation::{validate_single_match, Cache}, | |
| // }; | |
| // #[tokio::test] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
open_path_as_isenabled when opening Git repositories and only disable it for diff-based scans.--branch-root-commitcan be provided alongside--branch, letting you diff from a chosen commit while targeting a specific branch tip (still defaulting back to the--branchref when the commit is omitted).