Fixes TextInput component types #3197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruugey
requested review from
TheSonOfThomp and
Copilot
and removed request for
a team
🦋 Changeset detectedLatest commit: 1ee7daa The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the TypeScript types for the TextInput component to properly support React refs. The primary change updates the component's type definition from ComponentPropsWithoutRef to ComponentPropsWithRef, enabling proper ref forwarding to the underlying HTML input element.
Key changes:
- Updated TextInput component types to accept refs properly
- Added tests to verify ref functionality for both TextInput and TextArea components
- Updated package versions and added changeset documentation
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
tools/install/src/ALL_PACKAGES.ts |
Added new packages to the installation list |
packages/text-input/src/TextInput/TextInput.types.ts |
Changed from ComponentPropsWithoutRef to ComponentPropsWithRef for proper ref support |
packages/text-input/src/TextInput/TextInput.spec.tsx |
Added test for ref functionality and reorganized existing type tests |
packages/text-area/src/TextArea/TextArea.spec.tsx |
Added test for TextArea ref functionality |
packages/emotion/src/version.ts |
Version bump from 5.0.2 to 5.0.3 |
.changeset/eleven-cars-obey.md |
Added changeset documentation for the TextInput fix |
6 tasks
|
Size Change: 0 B Total Size: 1.59 MB ℹ️ View Unchanged
|
tools/install/src/ALL_PACKAGES.ts
Outdated
| '@leafygreen-ui/avatar', | ||
| '@leafygreen-ui/badge', | ||
| '@leafygreen-ui/banner', | ||
| '@leafygreen-ui/box', |
There was a problem hiding this comment.
need to rm the /box dir from your file system in order to prevent this
kraenhansen
reviewed
Oct 8, 2025
| /* eslint-disable jest/no-disabled-tests */ | ||
| describe.skip('types behave as expected', () => { | ||
| test('TextArea throws error when neither aria-labelledby or label is supplied', () => { | ||
| describe('types behave as expected', () => { |
There was a problem hiding this comment.
Curious why the skip was moved here and removed entirely from packages/text-input/src/TextInput/TextInput.spec.tsx. Seems inconsistent and perhaps a mistake?
There was a problem hiding this comment.
Technically should still be skipped, since there's no expect statement
kraenhansen
approved these changes
Oct 8, 2025
There was a problem hiding this comment.
The actual fix seems fine to me 👍
Although some of the changes seems unrelated to the fix 🤔
(although I did see opportunities for drive-by, non-breaking alignment across the packages, which was not picked up from #3167 🙈)
TheSonOfThomp
approved these changes
Oct 9, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
🎟 Jira ticket: Name of ticket
✅ Checklist
For new components
For bug fixes, new features & breaking changes
pnpm changesetand documented my changes🧪 How to test changes