LG-3972: Adds disabledSend prop to InlineMessageFeedback #3203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruugey
requested review from
Copilot and
nlarew
and removed request for
a team
🦋 Changeset detectedLatest commit: 2ba2114 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
Adds a disabledSend prop to the InlineMessageFeedback component to provide external control over the submit button's disabled state. This enhancement allows parent components to disable the submit functionality based on external conditions beyond the existing internal validation.
- Adds
disabledSendboolean prop with default value offalse - Updates submit button disabled logic to include the new prop
- Includes test coverage for the new functionality
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| InlineMessageFeedback.types.ts | Adds type definition for the new disabledSend prop |
| InlineMessageFeedback.tsx | Implements the prop destructuring and button disabled logic |
| InlineMessageFeedback.spec.tsx | Adds test case to verify the prop functionality |
| .changeset/funny-fans-punch.md | Documents the change for release notes |
|
Size Change: +232 B (+0.01%) Total Size: 1.59 MB
ℹ️ View Unchanged
|
tsck
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
InlineMessageFeedback provides a way to disable the Submit button
🎟 Jira ticket: Name of ticket
✅ Checklist
For new components
For bug fixes, new features & breaking changes
pnpm changesetand documented my changes🧪 How to test changes