Updates title prop in Chart Card #3213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruugey
requested review from
Copilot and
stephl3
and removed request for
a team
🦋 Changeset detectedLatest commit: 3e99abd The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
Updates the title prop type in ChartCard from string to React.ReactNode to support more flexible title content including JSX elements.
- Changes the
titleprop type fromstringtoReact.ReactNodein the TypeScript interface - Updates documentation to reflect the new prop type
- Adds changeset documenting the minor breaking change
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| charts/chart-card/src/ChartCard/ChartCard.types.ts | Updates title prop type from string to React.ReactNode |
| charts/chart-card/README.md | Updates documentation table to reflect new title prop type |
| .changeset/fine-phones-marry.md | Documents the breaking change for release notes |
tsck
reviewed
Oct 13, 2025
| * The title of the card | ||
| */ | ||
| title: string; | ||
| title: React.ReactNode; |
There was a problem hiding this comment.
If we want to completely open this up to anything, then I think we should probably do the same for an individual ChartHeader https://github.com/mongodb/leafygreen-ui/blob/main/charts/core/src/ChartHeader/ChartHeader.types.ts#L8
|
Size Change: 0 B Total Size: 1.59 MB ℹ️ View Unchanged
|
tsck
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
🎟 Jira ticket: Name of ticket
✅ Checklist
For new components
For bug fixes, new features & breaking changes
pnpm changesetand documented my changes🧪 How to test changes