Skip to content

Conversation

blink1073
Copy link
Member

No description provided.

@blink1073 blink1073 requested a review from a team as a code owner September 4, 2024 01:34
@blink1073 blink1073 requested review from NoahStapp and removed request for a team September 4, 2024 15:30
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really the only change we need to make to support 3.13? Wow!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had been testing in GitHub Actions, but now in EVG as well. 😄

@ShaneHarvey
Copy link
Member

Are we testing Python 3.13 on evergreen?

@ShaneHarvey
Copy link
Member

Also are the python test failures on Evergreen expected?

@blink1073
Copy link
Member Author

@ShaneHarvey
Copy link
Member

Still think we should add 3.13 testing on evergreen if possible.

@blink1073
Copy link
Member Author

Still think we should add 3.13 testing on evergreen if possible.

Yep, I have that done locally, I'm running patch builds to figure out the test failure.

@blink1073
Copy link
Member Author

Okay, I found the issue: we need to use the same version of crypt_shared, the one downloaded during run-orchestration.sh.

@blink1073 blink1073 requested a review from NoahStapp September 5, 2024 20:45
Copy link
Member

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blink1073
Copy link
Member Author

Still need to add 3.13 here: master/bindings/python/.evergreen/test.sh

Done

@ShaneHarvey
Copy link
Member

Note the test_fork failure is tracked by https://jira.mongodb.org/browse/PYTHON-4738.

@blink1073 blink1073 merged commit 4766876 into mongodb:master Sep 6, 2024
43 of 44 checks passed
@blink1073 blink1073 deleted the PYTHON-4321 branch September 6, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants