-
Notifications
You must be signed in to change notification settings - Fork 99
PYTHON-4321 Add support for Python 3.13 and update changelog for 1.11.0 release #885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
"Programming Language :: Python :: 3.10", | ||
"Programming Language :: Python :: 3.11", | ||
"Programming Language :: Python :: 3.12", | ||
"Programming Language :: Python :: 3.13", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really the only change we need to make to support 3.13? Wow!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had been testing in GitHub Actions, but now in EVG as well. 😄
Are we testing Python 3.13 on evergreen? |
Also are the python test failures on Evergreen expected? |
One set of failures is fixed by mongodb-labs/drivers-evergreen-tools#487. I'm not sure why the one test is failing, I've yet to see a difference between this PR and https://spruce.mongodb.com/task/mongo_python_driver_tests_python_version_rhel8_test_encryption__platform~rhel8_auth_ssl~noauth_nossl_python_version~3.12_encryption~encryption_crypt_shared_test_8.0_sharded_cluster_4e74c8274e7c4cb7658d445d526dcc33ced1750b_24_09_04_12_58_14/logs?execution=0. |
Still think we should add 3.13 testing on evergreen if possible. |
Yep, I have that done locally, I'm running patch builds to figure out the test failure. |
Okay, I found the issue: we need to use the same version of crypt_shared, the one downloaded during |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still need to add 3.13 here: https://github.com/mongodb/libmongocrypt/blob/master/bindings/python/.evergreen/test.sh
Done |
Note the test_fork failure is tracked by https://jira.mongodb.org/browse/PYTHON-4738. |
No description provided.