Skip to content

Conversation

erwee
Copy link
Collaborator

@erwee erwee commented Jan 29, 2025

No description provided.

@erwee erwee requested review from kevinAlbs and marksg07 January 29, 2025 17:17
@erwee erwee marked this pull request as ready for review January 29, 2025 17:17
@erwee erwee requested a review from marksg07 January 29, 2025 22:23
@erwee erwee requested a review from marksg07 January 30, 2025 20:58
Copy link
Contributor

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comments.

common.collectionsLevel1Token,
common.serverTokenDerivationLevel1Token,
status)) {
goto fail;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
goto fail;
_mongocrypt_buffer_cleanup(&asBsonValue);
goto fail;

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! thanks!

Copy link
Collaborator

@marksg07 marksg07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more small optimization.

@erwee erwee requested a review from marksg07 January 31, 2025 20:40
Copy link
Collaborator

@marksg07 marksg07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@erwee erwee merged commit ecb7614 into mongodb:master Feb 3, 2025
50 of 53 checks passed
@erwee erwee deleted the erwee/MONGOCRYPT-762 branch February 3, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants