MONGOCRYPT-770 do not warn if local schema does not require encryption #947
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Do not warn if local schema does not require encryption
Verified by this patch build: https://spruce.mongodb.com/version/679f718a7f3b450007729cee
Background & Motivation
libmongocrypt currently logs a warning if a response from query analysis (mongocryptd/crypt_shared) indicates a local schema does not require encryption. However, this log is generated even for an empty local schema. I do not expect configuring an empty local schema to be discouraged. Quoting the spec:
I expect this warning was intended to inform users that non-encryption JSON schema validation does not apply. However, mongocryptd already errors if a local schema is sent with JSON schema keywords that do not apply. Example:
Query analysis 8.1 supports a new field
csfleEncryptionSchemas
to accept multiple JSON Schemas. The repliedschemaRequiresEncryption
only indiciates if any of the sent schemas require encryption. Multiple schemas further complicates this warning check (E.g. should libmongocrypt warn if"schemaRequiresEncryption": false
and all schemas are local and non-empty?).Since the warning seems flawed and redundant with checks done in query analysis, this PR proposes removing.