MONGOCRYPT-772 Add strEncodeVersion to the encrypted field config

[marksg07]

When the EncryptedFieldConfig from collinfo or setopt_encrypted_field_config contains at least one field with a text search query type, we add the strEncodeVersion field with the latest version. If the field already exists, we check it for validity. We also copy this field from the EFC to the encryptedFields field of a create command. If this field already has strEncodeVersion, we check that it's equal to what's on the EFC.

[kevinAlbs]

LGTM with minor comments.

[kevinAlbs]

Though this follows other test patterns in this file, consider adding a macro to reduce repetition of the isMaster command (since it is not the subject of the test):

#define reply_to_ismaster(ctx)                                                                                         \
    if (1) {                                                                                                           \
        ASSERT_STATE_EQUAL(mongocrypt_ctx_state(ctx), MONGOCRYPT_CTX_NEED_MONGO_MARKINGS);                             \
        {                                                                                                              \
            mongocrypt_binary_t *cmd_to_mongocryptd = mongocrypt_binary_new();                                         \
                                                                                                                       \
            ASSERT_OK(mongocrypt_ctx_mongo_op(ctx, cmd_to_mongocryptd), ctx);                                          \
            ASSERT_MONGOCRYPT_BINARY_EQUAL_BSON(TEST_FILE("./test/data/fle1-create/without-schema/"                    \
                                                          "ismaster-to-mongocryptd.json"),                             \
                                                cmd_to_mongocryptd);                                                   \
            mongocrypt_binary_destroy(cmd_to_mongocryptd);                                                             \
            ASSERT_OK(mongocrypt_ctx_mongo_feed(ctx,                                                                   \
                                                TEST_FILE("./test/data/fle1-create/without-schema/"                    \
                                                          "mongocryptd-ismaster.json")),                               \
                      ctx);                                                                                            \
            ASSERT_OK(mongocrypt_ctx_mongo_done(ctx), ctx);                                                            \
        }                                                                                                              \
    } else                                                                                                             \
        (void)0

[kevinAlbs]

Suggested change

	CLIENT_ERR("expected 'strEncodeVersion' to be type int32, got: %d", bson_iter_type(&iter));
	CLIENT_ERR("expected 'strEncodeVersion' to be type int32, got: %s",
	mc_bson_type_to_string(bson_iter_type(&iter)));

To print string version of type on error.

[kevinAlbs]

Suggested change

	CLIENT_ERR("'strEncodeVersion' of %d is not supported", version);
	CLIENT_ERR("'strEncodeVersion' of %" PRId32 " is not supported", version);

To match int32_t argument.

[kevinAlbs]

Suggested change

	const uint8_t *data;
	uint32_t len;
	if (!BSON_ITER_HOLDS_DOCUMENT(&ef_iter)) {
	CLIENT_ERR(
	"_fle2_fixup_encryptedFields_strEncodeVersion: Expected encryptedFields to be type obj, got: %d",
	bson_iter_type(&ef_iter));
	goto fail2;
	}
	bson_iter_document(&ef_iter, &len, &data);
	if (!bson_init_static(&ef, data, len)) {
	CLIENT_ERR("_fle2_fixup_encryptedFields_strEncodeVersion: bson_init_static failed");
	goto fail2;
	}
	if (!mc_iter_document_as_bson(&ef_iter, &ef, status)) {
	goto fail2;
	}

[erwee]

Can't we use just a single helper function to do all the create test cases, parameterized by the expectation files?