-
Notifications
You must be signed in to change notification settings - Fork 98
MONGOCRYPT-711 remove implementation for Range-V1 #978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `concatenate_leaf` RangeV2 concatenates the leaf. Text search does not.
mdb-ad
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove code for supporting the Range-V1 protocol.
The diff is large. Most changes are mechanical removals of
use_range_v2arguments, and are done on separate commits to ease review.Background & Motivation
MongoDB 8.0 dropped Range-V1 and added stable support of Range-V2 (SPM-3583). libmongocrypt enabled the Range-V2 protocol in MONGOCRYPT-661 and did not provide public API to disable. libmongocrypt 1.11.0+ is only expected to produce Range-V2 payloads.
Relation to QE-V1/QE-V2
#934 relatedly removed QE-V1 code from libmongocrypt. The QE-V1 protocol was removed in MongoDB 7.0. QE-V1 could produce Range-V1 payloads. QE-V2 was enabled in libmongocrypt 1.8.0, before Range-V2 was enabled in 1.11.0. Therefore:
This PR adds decryption tests with older payloads to ensure decryption is preserved. Supporting decryption may not be strictly needed since QE-V1 and Range-V1 were documented as experimental. But supportind decryption does not appear to require much added implementation.
Test payloads
Test payloads are updated from V1 to V2 as needed. dump_payload was used to identify payloads: