Skip to content

Conversation

blva
Copy link
Collaborator

@blva blva commented Sep 26, 2025

Proposed changes

while sorting out our release, @drichmdb mentioned that these keys are no longer used and we only need barque, so trying to cleanup unused items in our release.

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

Copy link
Contributor

@drichmdb drichmdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blva blva requested a review from drichmdb October 6, 2025 11:06
@blva blva marked this pull request as ready for review October 6, 2025 11:06
@blva blva requested a review from a team as a code owner October 6, 2025 11:06
Copy link
Collaborator

@cveticm cveticm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
If the signing_auth_token_xx keys are stored in 1password, it would be great to remove them to keep the vault clean.

@blva
Copy link
Collaborator Author

blva commented Oct 6, 2025

If the signing_auth_token_xx keys are stored in 1password, it would be great to remove them to keep the vault clean.

yes, great point! I'll check where they're stored for clean up but only after some successful releases to make sure it's all good!

Copy link
Contributor

@drichmdb drichmdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blva blva merged commit 9e9c14c into master Oct 6, 2025
27 checks passed
@blva blva deleted the barque-cleanup branch October 6, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants