WIP Helper pattern #537
Closed
WIP Helper pattern #537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MCK 1.6.0 Release NotesNew Features
Bug Fixes
|
lsierant
reviewed
Oct 21, 2025
| // readState abstract reading the state of the resource that we store on the cluster between reconciliations. | ||
| func (h *ReplicaSetReconcilerHelper) readState() (*ReplicaSetDeploymentState, error) { | ||
| // Try to get the last achieved spec from annotations and store it in state | ||
| if lastAchievedSpec, err := h.resource.GetLastSpec(); err != nil { |
There was a problem hiding this comment.
this should probably one-off migration step?
There was a problem hiding this comment.
For now it's not a migration, I just abstracted the state reading/writing in a separate function (instead of randomly accessing annotations during the reconcile)
It will make more sense with a more complex state. I may even use the state_store at that point
lsierant
reviewed
Oct 21, 2025
|
|
||
| // Reconcile reads that state of the cluster for a MongoDbReplicaSet object and makes changes based on the state read | ||
| // and what is in the MongoDbReplicaSet.Spec | ||
| func (r *ReconcileMongoDbReplicaSet) Reconcile(ctx context.Context, request reconcile.Request) (res reconcile.Result, e error) { |
There was a problem hiding this comment.
consider putting real controller in one file and the helper in another mongodbreplicaset_reconciler_helper to separate clearly what's being executed in real Reconcile even, and what as part of the helper
|
Closed in favor of #544 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Proof of Work
Checklist
skip-changeloglabel if not needed