Skip to content

Conversation

jamis
Copy link
Contributor

@jamis jamis commented Oct 16, 2025

Updates the release references to point to the canonical repo.

@jamis jamis requested a review from a team as a code owner October 16, 2025 19:13
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the release workflow to use the canonical mongodb-labs/drivers-github-tools actions and removes deprecated Silk asset configuration.

  • Switches pr-check, build, and publish actions to mongodb-labs/drivers-github-tools at v3.
  • Removes SILK_ASSET_GROUP env var and silk_asset_group publish input, aligning with the updated action interface.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

- name: "Run the check action"
id: check
uses: jamis/drivers-github-tools/ruby/pr-check@ruby-3643-update-release-process
uses: mongodb-labs/drivers-github-tools/ruby/pr-check@v3
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For supply-chain safety, pin actions to an immutable commit SHA rather than a floating tag. Consider updating to something like uses: mongodb-labs/drivers-github-tools/ruby/pr-check@ and documenting the process to bump SHAs when upgrading.

Suggested change
uses: mongodb-labs/drivers-github-tools/ruby/pr-check@v3
# Pin to a specific commit SHA for supply-chain safety. To upgrade, update the SHA below to the latest for v3: https://github.com/mongodb-labs/drivers-github-tools/commits/v3
uses: mongodb-labs/drivers-github-tools/ruby/pr-check@c0ffee1234567890abcdef1234567890abcdef12

Copilot uses AI. Check for mistakes.

steps:
- name: "Run the build action"
uses: jamis/drivers-github-tools/ruby/build@ruby-3643-update-release-process
uses: mongodb-labs/drivers-github-tools/ruby/build@v3
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pin this action to a specific commit SHA instead of the v3 tag to mitigate the risk of a compromised or re-tagged action. Example: uses: mongodb-labs/drivers-github-tools/ruby/build@.

Suggested change
uses: mongodb-labs/drivers-github-tools/ruby/build@v3
uses: mongodb-labs/drivers-github-tools/ruby/build@a1b2c3d4e5f6g7h8i9j0k1l2m3n4o5p6q7r8s9t0

Copilot uses AI. Check for mistakes.

steps:
- name: "Run the publish action"
uses: jamis/drivers-github-tools/ruby/publish@ruby-3643-update-release-process
uses: mongodb-labs/drivers-github-tools/ruby/publish@v3
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, pin the publish action to a commit SHA (e.g., uses: mongodb-labs/drivers-github-tools/ruby/publish@) rather than a mutable major tag.

Suggested change
uses: mongodb-labs/drivers-github-tools/ruby/publish@v3
uses: mongodb-labs/drivers-github-tools/ruby/publish@<commit-sha-for-v3>

Copilot uses AI. Check for mistakes.

Comment on lines 83 to 86
product_name: ${{ env.PRODUCT_NAME }}
product_id: ${{ env.PRODUCT_ID }}
release_message: ${{ needs.check.outputs.message }}
silk_asset_group: ${{ env.SILK_ASSET_GROUP }}
ref: ${{ needs.check.outputs.ref }}
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The silk_asset_group input and SILK_ASSET_GROUP env were removed in this PR. If internal release runbooks or docs referenced these, please update them to reflect the new v3 publish action interface.

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant