Implemented deleteImage API, state and tests #945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlymonkai
reviewed
Oct 9, 2025
| const newImages = images.filter((image) => image.id !== payload.imageId); | ||
| return { | ||
| ...state, | ||
| images: [...newImages], |
There was a problem hiding this comment.
Delete the imageID for the following object:
- Damages
- Parts
- renderedOutputs
- views
gabrieltmonkai
force-pushed
the
feat/MN-780/create-deleteImage-api
branch
from
3ab10ff to
4121c7f
Compare
dlymonkai
reviewed
Oct 9, 2025
| } | ||
| const newImages = images.filter((image) => image.id !== payload.imageId); | ||
| const newDamages = damages.filter((damage) => !damage.relatedImages.includes(payload.imageId)); | ||
| const newParts = parts.filter((part) => !part.relatedImages.includes(payload.imageId)); |
There was a problem hiding this comment.
This will removed every part that have a deleted image ID related to it, we don't want that.
We want to only remove the id in the relatedImages array.
gabrieltmonkai
force-pushed
the
feat/MN-780/create-deleteImage-api
branch
6 times, most recently
from
0d71d60 to
0788148
Compare
Reset state objects containing the deleted image Updated objects to be deleted in State Updated API export and added more tests Added docs
gabrieltmonkai
force-pushed
the
feat/MN-780/create-deleteImage-api
branch
from
0788148 to
cf49a7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Jira Ticket Reference : MN-780
Added a new
deleteImagefunction to handle image deletion of an inspection.Checklist before requesting a review