Skip to content

Conversation

@Eijebong
Copy link
Contributor

@Eijebong Eijebong commented Oct 8, 2025

This is very weird because of iOS weekly releases. Since they don't do
"proper" betas, we consider the RC (X.0) as the latest beta version and
any other version as a proper release.

@Eijebong Eijebong requested a review from a team as a code owner October 8, 2025 15:43
@rvandermeulen
Copy link

We don't have Beta versions like this for iOS with weekly release

@Eijebong
Copy link
Contributor Author

Eijebong commented Oct 8, 2025

Right, I misunderstood the issue... So X.0 are now betas and anything with a minor version >= 1 is a release?

@Eijebong Eijebong marked this pull request as draft October 8, 2025 15:56
@rvandermeulen
Copy link

No, we ship X.0 releases also alongside the regular Firefox train releases

@Eijebong
Copy link
Contributor Author

Eijebong commented Oct 8, 2025

Right... So basically here we should always return the latest version matching exactly X.0 as ios_beta_version and the latest version released found as ios_version. Is that correct?

@rvandermeulen
Copy link

In #c0 of the bug I filed, I described how I think it should work. I think whatever build is currently in RC should be treated as the Beta here, and whatever one is currently being shipped as Release.

This is very weird because of iOS weekly releases. Since they don't do
proper betas, we consider the RC (X.0) as the latest beta version and
any other version as a proper release.
@Eijebong Eijebong force-pushed the ios-mobile-versions-json branch from 8fbcac7 to d4566e1 Compare October 8, 2025 16:11
@Eijebong Eijebong marked this pull request as ready for review October 8, 2025 16:11
Copy link
Contributor

@jcristau jcristau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to match what Ryan is suggesting in the bug, which (AIUI) would see beta updated when a release's promote phase runs, not just after it's shipped?

@Eijebong
Copy link
Contributor Author

Eijebong commented Oct 9, 2025

You're right... Because get_releases_from_db only returns shipped versions. This was supposed to be an easy fix 😭

@Eijebong Eijebong marked this pull request as draft October 13, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants