-
Notifications
You must be signed in to change notification settings - Fork 27
Bug 1993054 - Add iOS versions to mobile product details #1797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
We don't have Beta versions like this for iOS with weekly release |
|
Right, I misunderstood the issue... So X.0 are now betas and anything with a minor version >= 1 is a release? |
|
No, we ship X.0 releases also alongside the regular Firefox train releases |
|
Right... So basically here we should always return the latest version matching exactly |
|
In #c0 of the bug I filed, I described how I think it should work. I think whatever build is currently in RC should be treated as the Beta here, and whatever one is currently being shipped as Release. |
This is very weird because of iOS weekly releases. Since they don't do proper betas, we consider the RC (X.0) as the latest beta version and any other version as a proper release.
8fbcac7 to
d4566e1
Compare
jcristau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem to match what Ryan is suggesting in the bug, which (AIUI) would see beta updated when a release's promote phase runs, not just after it's shipped?
|
You're right... Because get_releases_from_db only returns shipped versions. This was supposed to be an easy fix 😭 |
This is very weird because of iOS weekly releases. Since they don't do
"proper" betas, we consider the RC (X.0) as the latest beta version and
any other version as a proper release.