This repository was archived by the owner on Feb 11, 2020. It is now read-only.
Fix #2161 - don't (try to) pass window.grecaptcha.execute to expectRecaptcha which is going to wait for grecaptcha to become awailable. #2162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xpectRecaptcha which is going to wait for grecaptcha to become awailable.
Contributor
|
CC @alanmoo do you know who could review this? |
cadecairos
suggested changes
Oct 2, 2019
Comment on lines
+91
to
+94
| setTimeout(() => { | ||
| this.expectRecaptcha(callback); | ||
| }, 100); | ||
| return; |
Contributor
There was a problem hiding this comment.
Why this change? It doesn't appear to do anything
Contributor
Author
There was a problem hiding this comment.
Strictly not necessary, it doesn't change the behaviour. But it's not good practice to have methods that sometimes return something (well undefined, so not much) and sometimes not, as some linters will tell you...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the time window.grecaptcha could still be unavailable. So, only access it after we know it's there.
I think this should work. But I don't get a captcha when testing locally with or without this patch... so unable to verify.