feat(nimbus): Disable slack notifications toggle #14236
Open
+268
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashikakhurana
requested review from
freshstrangemusic and
jaredlockhart
as code owners
Contributor
Author
|
Collaborator
|
This is a great idea, but i'd change the label to and have it default enabled |
Contributor
Author
|
Contributor
Author
|
okay now it says |
jaredlockhart
previously requested changes
Jan 5, 2026
Collaborator
jaredlockhart
left a comment
jaredlockhart
left a comment
There was a problem hiding this comment.
Yep looks great just combine the two migrations into one 🙏
| @@ -0,0 +1,22 @@ | |||
| # Generated by Django 5.2.9 on 2025-12-19 19:23 | |||
|
|
|||
Collaborator
There was a problem hiding this comment.
Ah you can fold these two migrations together 🙏
Contributor
Author
There was a problem hiding this comment.
you are right we don't need two fields migrations, removed the old one, just for the new filed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This commit
Fixes #14230