Skip to content

Conversation

@dschom
Copy link
Contributor

@dschom dschom commented Dec 16, 2025

Because

  • After upgrading a session, a 'signin confirmation' email is being sent out unintentionally.
  • It appears the cache is corrupt.

This pull request

  • Checks in with the server, instead of relying on the cache.
  • Since this email isn't critical, it's simply a notification, the extra overhead isn't really perceptible to a end user.

Issue that this pull request solves

Closes: FXA-12781

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Steps to reproduce

  • Sign into settings
  • Change your password
  • Watch your inbox, with this fix in place, you should no longer receive an email with subject: Use $CODE to sign in

@dschom dschom requested a review from a team as a code owner December 16, 2025 17:32
@dschom dschom force-pushed the FXA-12781 branch 3 times, most recently from a097874 to 6396851 Compare December 17, 2025 19:49
@dschom dschom changed the title wip bug(settings): Fix extraneous sign in email Dec 17, 2025
Copy link
Contributor

@vbudhram vbudhram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dschom Verified locally 👍🏽

@dschom dschom merged commit 7103b79 into main Dec 31, 2025
22 checks passed
@dschom dschom deleted the FXA-12781 branch December 31, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants