Removing quoted timestamps from v2 reader #1113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leplatrem
reviewed
Dec 22, 2025
git-reader/app.py
Outdated
| for signature in metadata["signatures"]: | ||
| x5u = signature["x5u"] | ||
| rewritten_x5u = f"{request.url.scheme}://{request.url.netloc}/{API_PREFIX}cert-chains/{parsed.path.lstrip('/')}" | ||
| signature["x5u"] = rewritten_x5u |
Contributor
There was a problem hiding this comment.
Good catch!
We are sure that /v2 will support signatures
And we are pretty sure that we won't run git-export on old servers.
So, here we can assume that we only care about signatures
Contributor
Author
There was a problem hiding this comment.
So you're saying we can probably drop lines 625-626? Or do you wanna keep both for now?
Contributor
There was a problem hiding this comment.
I would drop if metadata["signatures"] is not None:
Contributor
Author
There was a problem hiding this comment.
Ah, can do. I was being extra paranoid.
alexcottner
force-pushed
the
v2-no-quotes
branch
from
142de58 to
b5ec7de
Compare
…annotated path params
leplatrem
approved these changes
Dec 22, 2025
git-reader/app.py
Outdated
| for signature in metadata["signatures"]: | ||
| x5u = signature["x5u"] | ||
| rewritten_x5u = f"{request.url.scheme}://{request.url.netloc}/{API_PREFIX}cert-chains/{parsed.path.lstrip('/')}" | ||
| signature["x5u"] = rewritten_x5u |
Contributor
There was a problem hiding this comment.
I would drop if metadata["signatures"] is not None:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git-reader will not use quoted timestamps.
We will be updating the client accordingly.
Also adding URI rewrite logic for
signatureslist.See #1104