WebGLRenderer: Fix V8 deoptimizations #32400
Open
+125
−60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enforces consistent object shapes (Hidden Classes) for
materialProperties,textureProperties, andrenderTargetPropertiesto enable monomorphic property access in V8, resulting in a ~3.4x performance improvement in property lookups.Additionally:
deletekeyword usage withundefinedassignment forrenderTargetPropertiesto prevent hidden class transitions.bindingStates,programMap, andstateMapto useMapinstead of plain objects, eliminatingdeleteusage in hot paths._materialCacheto useMapinstead of plain objects, eliminatingdeleteusage.