Skip to content

Conversation

rafathasan
Copy link

In this pull request, I've addressed multiple issues in the script:

  • Port Assignment Logic: Previously, the port argument was not correctly assigned in the ApiRos class, leading to a TypeError when establishing the API connection. This issue has been fixed by modifying the __init__ method to properly handle the port argument, ensuring it is correctly assigned and used for the API connection.

  • SSL Wrapping: I've commented out the SSL wrapping section to prevent potential errors during the initial connection setup. Since SSL functionality wasn't explicitly required for the script, this change eliminates any potential complications.

  • Main Function Update: The main function has been updated to correctly convert the port argument to an integer before passing it to the ApiRos class. This ensures consistency and avoids potential type-related errors when working with the port value.

These changes improve the reliability and functionality of the script, addressing various issues and ensuring smooth execution of the API connection process.

@ivanbelenky
Copy link

@mrhenrike can you please merge this? I ran into the same bug recently, almost created a similar PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants