Feature | Support onBytesWrittenVideo to receive bytes on JS while recording Video #3549
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR Adds the
onBytesWrittenVideo
callback in order to receive the bytes of the video while it is being recorded.Changes
IOS
DispatchSourceTimer
on Ios in order to read the file size from the FileSystem every 400 ms, that will be executed after the video has started and when finished the timer is cleaned.onBytesWrittenVideoEvent
asRCTDirectEventBlock
in order to send events to JS inRCTViewManager
Android
onBytesWrittenVideo
on thegetExportedCustomDirectEventTypeConstants
and all the logic to treat that as an Event and send data to JSVideoRecordEvent.Status
as it is available thereTSX/TS
NativeEvent
to just expose(bytes: number) => void
Docs
Tested on
Related issues