Add option to build without sound (default sound on) #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help development and debugging as well as use on systems without sound hardware or sound libraries, enable option to build without sound on Windows, MacOS, Linux and similar.
By default, the sound is on as before.
This was implemented by cut/paste the sound-relevant parts of spec_win.cpp to win_sound.cpp and spec_nix.cpp to pulse_audio.cpp. When sound is not enabled, the definitions are stubbed in to allow building without using them in sound_stub.cpp.
Makefile and build.sh were updated to add pulse_audio.cpp.
Also, changed conf.[h,cpp] to have Unix style line endings like the rest of the project source code files.