Skip to content

Fix#32 #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Fix#32 #33

wants to merge 8 commits into from

Conversation

chrstnbwnkl
Copy link
Contributor

Since HereMaps' isochrones() method possibly returns multiple polygons for one isochrone, the interface is now unified so that each provider's isochrone geometry now returns a list of polygons (with mostly one feature only).

@chrstnbwnkl chrstnbwnkl requested a review from nilsnolde June 28, 2021 07:25
nilsnolde
nilsnolde requested changes Jun 28, 2021
View reviewed changes
Copy link
Collaborator

@nilsnolde nilsnolde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Should we also update the tests for isochrones to test for the depth of the nested lists?

@chrstnbwnkl chrstnbwnkl requested a review from nilsnolde June 28, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilsnolde nilsnolde Awaiting requested review from nilsnolde

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrstnbwnkl @nilsnolde