Fixed two compilation error with ESP8266 2.6.3 core #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applied this correction: mtongnz#113 (comment)
The error in the core for which we should make (void *) cast is now fixed, so we must remove (void *)
This reverts commit 341825a.
This reverts commit 714e3e2.
Deleted previously for error
|
Mind providing a quick description of what you have done? |
Author
|
Hi. Thank you for your comment.
Before of the next week I'll revise my branch and I will open a new PR with a cleaned commit history.
…________________________________
From: Alexander Hoppe ***@***.***>
Sent: Friday, March 12, 2021 4:45:20 PM
To: mtongnz/ESP8266_ArtNetNode_v2 ***@***.***>
Cc: mrv96 ***@***.***>; Author ***@***.***>
Subject: Re: [mtongnz/ESP8266_ArtNetNode_v2] Fixed two compilation error with ESP8266 2.6.3 core (#125)
Mind providing a quick description of what you have done?
Just looking over your commits, you just seemed to have deleted some files.
After the description, I am very happy to approve this PR, and then we just have to wait for @mtongnz<https://github.com/mtongnz> to return!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#125 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADD27VSPZAF56VZ6WN62JFDTDIZJBANCNFSM4KOVGRMQ>.
|
Author
|
New cleaned PR opened: #133 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.