[autocomplete][combobox] Move CompositeList to the ComboboxList to make Input element work with composites #2883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuganzy
requested review from
atomiks,
colmtuite and
michaldudak
as code owners
commit: |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
zannager
added
scope: autocomplete
Bundle size report
|
|
Works with the PR release preview: https://codesandbox.io/p/sandbox/2883-forked-38q7wf |
chuganzy
force-pushed
the
autocomplete-composite
branch
from
f4c8d55 to
cc9bf54
Compare
chuganzy
force-pushed
the
autocomplete-composite
branch
from
cc9bf54 to
046f911
Compare
chuganzy
commented
Oct 6, 2025
| labelsRef.current = []; | ||
| } | ||
| }; | ||
| }, [labelsRef]); |
There was a problem hiding this comment.
The changes in CompoboxList revealed an issue where refs are not cleaned up on unmount, keeps holding all references to the elements. It caused the test fail in React 18 Strict Mode, because listRef is not empty on the second+ time on open and waitForListPopulated in useListNavigation assumes it is ready to navigate as soon as it opens.
This was not an issue in React 19 Strict Mode, since IndexGuessBehavior.GuessFromOrder behaved more accurately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just moves the
CompositeListfrom the Root element to the List to make Input element work with Composites, such as Toolbar.CodeSandbox: https://codesandbox.io/p/sandbox/quizzical-swanson-7q3yqh
It can move the focus from the input successfully because the keyboard event is handled by the CompositeRoot, however it cannot move back with arrow keys because the ComboboxInput is unavailable there but registered to the context in the ComboboxRoot(Internal).
As a side note, I am not sure if it is intended to enable focus roving on the input elements (or focusable elements in general) that is not rendered as CompositeItem. Somewhat relates to #2702.