[portals] Create portal elements inside React #2889
+651
−376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
Bundle size report
|
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
atomiks
force-pushed
the
feat/portal-elements
branch
from
39888ea to
f4cc9da
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
atomiks
force-pushed
the
feat/portal-elements
branch
3 times, most recently
from
a6e2dde to
66fcf91
Compare
atomiks
force-pushed
the
feat/portal-elements
branch
from
66fcf91 to
1cc28d8
Compare
atomiks
force-pushed
the
feat/portal-elements
branch
from
50a0c63 to
5d77d0f
Compare
github-actions
bot
added
the
PR: out-of-date
Signed-off-by: atomiks <cc.glows@gmail.com>
github-actions
bot
removed
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built off #2847
This makes the portal element (with the internal
id) a regular element rendered inside React. So you can pass props to it, access it with a ref, etc. Thecontainerprop is still used as a location to inject it.Closes #2887
Fixes #2780 (https://codesandbox.io/p/sandbox/kind-moon-fstqzf)