Skip to content

Fixes #4249 - isGuestAccount : return nil on invalid input #4312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes #4249 - isGuestAccount : return nil on invalid input #4312

wants to merge 1 commit into from
+1 −1

Conversation

MohabCodeX
Copy link

Fixes #4249

@botder botder added the backwards-incompatible Should be merged after the release of 1.6.1 label Jul 26, 2025
@FileEX
Copy link
Contributor

FileEX commented Jul 27, 2025

This isn't really backwards-incompatible, because false and nil are handled the same way in Lua, typically with

if (not something) then

So existing code will still behave the same. The chance that anyone did something like:

local b = isGuestAccount(acc)
if (type(b) == 'boolean') then

...is minimal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FileEX FileEX FileEX approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
backwards-incompatible Should be merged after the release of 1.6.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

isGuestAccount will return false for values that aren't accounts
3 participants
@MohabCodeX @FileEX @botder