-
Notifications
You must be signed in to change notification settings - Fork 2
Refactor components in transactions table #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,232
−1,494
Merged
Changes from 34 commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
375a288
Updated styles
MiroMargineanu f7c8cbd
Removed unused styles
MiroMargineanu 5049603
Removed unused styles
MiroMargineanu ecbcaf1
Updated styles
MiroMargineanu ed17b33
Updated CHANGELOG.md
MiroMargineanu b38a3f0
Updated icons
MiroMargineanu a3696d4
Updated CHANGELOG.md
MiroMargineanu 760702a
Removed unused icons
MiroMargineanu 449a592
Merge branch 'development' into mm-refactor-tailwind-css
MiroMargineanu c0c141c
Updated styles
MiroMargineanu 72f4669
Fixed conflicts
MiroMargineanu 24cd732
Updated styles
MiroMargineanu 902bba2
Merge branch 'development' into ic/feature/refactor-tailwind-css
iuliacimpeanu 0a0e0a4
Updated styles
iuliacimpeanu 8a1a2d2
Updated styles
iuliacimpeanu ce8310c
Updated shards arrow styles
iuliacimpeanu 6fa296b
Added icons to replace Fontawesome
iuliacimpeanu 5200eb7
Updated styles
iuliacimpeanu 33fb928
Fixed tests
iuliacimpeanu cb74c1c
Updated styles on transactions table
iuliacimpeanu de13a81
Refactored FontAwesome icons
iuliacimpeanu d5c2426
Fixed test
iuliacimpeanu 6344554
Updated scrollbar styles
iuliacimpeanu 55a1c6e
Fixes after review.
iuliacimpeanu 456e43b
Removed FontAwesome packages
iuliacimpeanu 1504522
Merge branch 'development' into ic/feature/refactor-tailwind-css
iuliacimpeanu f621f75
Updated icons
iuliacimpeanu 17b1c54
Fixed tests
iuliacimpeanu 38a453d
Fixes
iuliacimpeanu ae388f3
Fixes.
iuliacimpeanu 82e1bb9
Fixes
iuliacimpeanu 724a51b
Refactored transaction-age
iuliacimpeanu 35326a4
Merge branch 'development' into ic/feature/refactor-components
iuliacimpeanu 4b2c228
Updated changelog
iuliacimpeanu 83c724c
Fixed path
iuliacimpeanu 2f11372
Removed transaction-direction-badge component not used
iuliacimpeanu 8929b64
Refactored transaction-hash comp
iuliacimpeanu b61af8b
Refactored components from transactions-table
iuliacimpeanu 4693ebd
Refactored classNames
iuliacimpeanu 32d53b2
Updated changelog
iuliacimpeanu f335a86
Merge branch 'development' into ic/feature/refactor-components
iuliacimpeanu b075247
Merge branch 'development' into ic/feature/refactor-components
iuliacimpeanu 9bd96a3
Fixed tests
iuliacimpeanu 95502d0
Fixed tests
iuliacimpeanu 7410e5a
Updated TransactionIcon
iuliacimpeanu 8928c63
Updated TransactionIcon
iuliacimpeanu 0ecd244
Merge branch 'development' into ic/feature/refactor-components
iuliacimpeanu bb9c001
Updated default icon
iuliacimpeanu e4d8024
Fixes
iuliacimpeanu f0972e9
Fixes
iuliacimpeanu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -129,4 +129,4 @@ | |
"typescript": "^5.7.3", | ||
"vite": "^7.0.6" | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
src/components/controlled/transactions-table/TransactionAge/TransactionAge.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
import { h } from '@stencil/core'; | ||
import { DataTestIdsEnum } from 'constants/dataTestIds.enum'; | ||
|
||
// prettier-ignore | ||
const styles = { | ||
transactionAge: 'transaction-age mvx:w-max' | ||
} satisfies Record<string, string>; | ||
|
||
interface TransactionAgePropsType { | ||
age: string; | ||
class?: string; | ||
tooltip?: string; | ||
} | ||
|
||
export function TransactionAge({ age, tooltip, class: className }: TransactionAgePropsType) { | ||
const component = tooltip ? ( | ||
<div | ||
title={tooltip} | ||
data-testid={DataTestIdsEnum.transactionAge} | ||
class={{ [styles.transactionAge]: true, [className]: Boolean(className) }} | ||
> | ||
{age} | ||
</div> | ||
) : ( | ||
<div | ||
data-testid={DataTestIdsEnum.transactionAge} | ||
class={{ [styles.transactionAge]: true, [className]: Boolean(className) }} | ||
> | ||
{age} | ||
</div> | ||
); | ||
|
||
return <div class={{ [className]: Boolean(className), [styles.transactionAge]: true }}>{component}</div>; | ||
} |
1 change: 1 addition & 0 deletions
1
src/components/controlled/transactions-table/TransactionAge/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
export * from './TransactionAge' | ||
2 changes: 1 addition & 1 deletion
2
...saction-age/tests/transaction-age.spec.ts → ...nsactionAge/tests/transaction-age.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 0 additions & 1 deletion
1
src/components/controlled/transactions-table/components/transaction-age/transaction-age.scss
This file was deleted.
Oops, something went wrong.
38 changes: 0 additions & 38 deletions
38
src/components/controlled/transactions-table/components/transaction-age/transaction-age.tsx
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.