fix: ensure variables are initialized before goto

[alexs-sh]

Hello,

This commit adds variable initialization before goto statement can be executed. As a result, it prevents jumping to code that uses uninitialized variables.

Here is an example from IedConnection_setGoCBValuesAsync at client_goose_control.c

    if (separator == NULL)
    {
        *error = IED_ERROR_OBJECT_REFERENCE_INVALID;
        goto exit_function;
    }
...
   
    /* create the list of requested itemIds references */
    LinkedList itemIds = LinkedList_create();
    LinkedList values = LinkedList_create();

...
exit_function:
    LinkedList_destroy(itemIds);
    LinkedList_destroyStatic(values);

If separator is NULL, a goto exit_function is triggered. However, exit_function uses itemIds and values, which may be uninitialized since they are assigned after the goto.

This is a rare but possible issue, detectable with Clang and -Wsometimes-uninitialized flag.

Please let me know if any additional information, testing, or clarification is needed.

Thank you

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud