Skip to content

Fixes in config.go #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025
Merged

Fixes in config.go #14

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d0f31f
Improve log message when PORT env not set
eqsdxr May 28, 2025
f6c1f76
Fix error handling order
eqsdxr May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,16 +93,17 @@ func GetConfig() *Config {
}

cfg, err := ParseConfig(v)
if err != nil {
log.Fatalf("Error in parse config %v", err)
}

envPort := os.Getenv("PORT")
if envPort != "" {
cfg.Server.ExternalPort = envPort
log.Printf("Set external port from environment -> %s", cfg.Server.ExternalPort)
} else {
cfg.Server.ExternalPort = cfg.Server.InternalPort
log.Printf("Set external port from environment -> %s", cfg.Server.ExternalPort)
}
if err != nil {
log.Fatalf("Error in parse config %v", err)
log.Printf("Environment variable PORT not set; using internal port value -> %s", cfg.Server.ExternalPort)
}

return cfg
Expand Down