Added a new clear grid button functionality to enhance user experience when … #569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…drawing new bitmaps, found an issue where the bitmap was not displayed on the screen. This is likely due to something in the initialization, however, adding a console log which was originally just used for debugging solved this issue. That is not the optimal solution however, it works for now.
|
I also noticed this problem and will look into fixing it with perhaps a more robust approach. |
|
Yes, you were right about the issue being in the initialization. I think the problem was that the startup code assumes grid exists in localStorage while it might not actually. I decided to submit a different pull request (#579) because there were other features (such as importing png and bmp files) that should really be brought over to this platform. That pull request should resolve the loading issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…drawing new bitmaps. When trying to use the bitmap for one of the projects, I found an issue where the bitmap was not displayed on the screen upon first opening the bitmap editor. This is likely due to something in the initialization, however, adding a console log (initially used for debugging) in the Init function solved this issue. I think it just bought enough time. That is not an optimal solution however, it works for now.