Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the issue where clicking the "Dismiss" (X) button on individual notifications would close the entire notification panel instead of removing only that specific notification.
Problem
Solution
Changes Made
1. Fixed dismiss button event handling:
c-overlay__close-button
CSS class that was causing conflict with overlay close behavior@click.stop
and comprehensive event prevention to stop propagationdismissNotification()
method with proper event handling2. Improved notification panel behavior:
3. Enhanced component communication:
Files Modified
src/plugins/notificationIndicator/components/NotificationMessage.vue
dismissNotification()
method with proper event preventionnotification-dismissed
event emissionsrc/plugins/notificationIndicator/components/NotificationsList.vue
Testing
Manual Testing Steps
Expected Behavior
Backwards Compatibility
info
notifications unchangedFixes
Closes #8103