Skip to content

Conversation

shefalijoshi
Copy link
Contributor

Closes #977

Describe your changes:

If the time system is UTC based, generate x-axis time-series ticks that follow a better pattern than a random set of ticks.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

Copy link

codecov bot commented Aug 18, 2025

Codecov Report

❌ Patch coverage is 94.73684% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.43%. Comparing base (569c7ff) to head (1646bad).

Files with missing lines Patch % Lines
src/plugins/plot/tickUtils.js 93.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8139      +/-   ##
==========================================
- Coverage   57.23%   56.43%   -0.80%     
==========================================
  Files         700      700              
  Lines       28142    28179      +37     
  Branches     2744     2745       +1     
==========================================
- Hits        16107    15904     -203     
- Misses      11695    11935     +240     
  Partials      340      340              
Flag Coverage Δ
e2e-ci 62.19% <93.33%> (-0.87%) ⬇️
e2e-full 23.54% <3.33%> (-18.80%) ⬇️
unit 48.37% <65.78%> (+0.01%) ⬆️
Files with missing lines Coverage Δ
src/plugins/plot/MctPlot.vue 37.41% <100.00%> (+0.26%) ⬆️
src/plugins/plot/MctTicks.vue 78.94% <100.00%> (+0.68%) ⬆️
src/plugins/plot/axis/XAxis.vue 60.00% <100.00%> (+1.02%) ⬆️
src/plugins/plot/chart/MCTChartSeriesElement.js 79.66% <ø> (ø)
src/plugins/plot/draw/DrawWebGL.js 92.00% <ø> (ø)
src/plugins/plot/tickUtils.js 96.03% <93.33%> (-1.15%) ⬇️

... and 23 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 569c7ff...1646bad. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@jvigliotta jvigliotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change in the docs, then a couple questions. Ran this locally and it is WAY nicer than the ticks we currently have!

Copy link
Contributor

@jvigliotta jvigliotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOOKIN' GOOD!

@jvigliotta jvigliotta enabled auto-merge (squash) September 17, 2025 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Better Ticks

2 participants