Skip to content

Conversation

jvigliotta
Copy link
Contributor

Closes

Describe your changes:

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

davetsay added 30 commits April 15, 2024 15:52
fix listener in useTimeSystem
documentation update to useTimeBounds
many things broken
will need refactor to account for independent time conductor
reactivity fixes to composables
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

❌ Patch coverage is 31.54506% with 319 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.50%. Comparing base (5872b90) to head (710f3d7).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/plugins/correlationTelemetryPlugin/plugin.js 1.00% 99 Missing ⚠️
...Conductor/independent/IndependentTimeConductor.vue 0.00% 89 Missing ⚠️
src/plugins/timeConductor/DateTimePopupFixed.vue 12.76% 82 Missing ⚠️
src/plugins/timeConductor/TimePopupFixed.vue 0.00% 16 Missing ⚠️
src/plugins/timeConductor/TimePopupRealtime.vue 33.33% 6 Missing ⚠️
src/plugins/timeConductor/ConductorComponent.vue 79.16% 5 Missing ⚠️
...gins/timeConductor/independent/IndependentMode.vue 0.00% 4 Missing ⚠️
src/plugins/timeConductor/useClock.js 80.95% 4 Missing ⚠️
src/plugins/timeConductor/useTimeSystem.js 78.94% 4 Missing ⚠️
...ins/timeConductor/independent/IndependentClock.vue 0.00% 3 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8160      +/-   ##
==========================================
- Coverage   57.40%   55.50%   -1.91%     
==========================================
  Files         700      707       +7     
  Lines       28154    28226      +72     
  Branches     2749     2730      -19     
==========================================
- Hits        16163    15668     -495     
- Misses      11656    12231     +575     
+ Partials      335      327       -8     
Flag Coverage Δ
e2e-ci 59.87% <46.66%> (-3.34%) ⬇️
e2e-full 23.78% <41.90%> (-18.61%) ⬇️
unit 48.02% <30.47%> (-0.49%) ⬇️
Files with missing lines Coverage Δ
src/api/time/TimeContext.js 90.47% <100.00%> (ø)
src/plugins/plot/axis/XAxis.vue 60.00% <100.00%> (+1.02%) ⬆️
src/plugins/plugins.js 100.00% <100.00%> (ø)
src/plugins/timeConductor/ConductorClock.vue 37.50% <100.00%> (+16.07%) ⬆️
src/plugins/timeConductor/ConductorHistory.vue 49.54% <ø> (-1.37%) ⬇️
src/plugins/timeConductor/ConductorInputsFixed.vue 80.00% <100.00%> (ø)
.../plugins/timeConductor/ConductorInputsRealtime.vue 87.50% <100.00%> (+11.82%) ⬆️
src/plugins/timeConductor/ConductorMode.vue 100.00% <100.00%> (ø)
src/plugins/timeConductor/ConductorPopUp.vue 50.00% <100.00%> (-5.82%) ⬇️
src/plugins/timeConductor/ConductorTimeSystem.vue 32.43% <ø> (-1.78%) ⬇️
... and 23 more

... and 57 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5872b90...710f3d7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants