Skip to content

Conversation

charlesh88
Copy link
Contributor

@charlesh88 charlesh88 commented Oct 1, 2025

Closes #8171

Describe your changes:

  • Added { skipPrefix: true } to the format() call for the Time List's Expanded view countdown "hero" item.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [] Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@charlesh88 charlesh88 requested a review from davetsay October 1, 2025 18:36
@charlesh88 charlesh88 added the bug:visual Visual problem. Not a functional issue label Oct 1, 2025
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 56.71%. Comparing base (2494e2f) to head (1d968b7).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/plugins/timelist/ExpandedViewItem.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8172      +/-   ##
==========================================
- Coverage   57.16%   56.71%   -0.46%     
==========================================
  Files         704      704              
  Lines       28283    28283              
  Branches     2770     2770              
==========================================
- Hits        16169    16040     -129     
- Misses      11768    11899     +131     
+ Partials      346      344       -2     
Flag Coverage Δ
e2e-ci 63.17% <ø> (+0.02%) ⬆️
e2e-full 23.68% <ø> (-18.72%) ⬇️
unit 48.37% <0.00%> (+0.04%) ⬆️
Files with missing lines Coverage Δ
src/plugins/timelist/ExpandedViewItem.vue 5.76% <0.00%> (ø)

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2494e2f...1d968b7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@davetsay davetsay added this to the Release 4.2.0 milestone Oct 9, 2025
@davetsay davetsay merged commit 896d77a into master Oct 9, 2025
26 of 35 checks passed
@davetsay davetsay deleted the time-list-8171 branch October 9, 2025 20:42
@akhenry akhenry removed this from the Release 4.2.0 milestone Oct 15, 2025
@akhenry
Copy link
Contributor

akhenry commented Oct 15, 2025

Needs backmerged into gold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug:visual Visual problem. Not a functional issue type:bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Time List is displaying + and - twice

3 participants