Skip to content

Conversation

shefalijoshi
Copy link
Contributor

@shefalijoshi shefalijoshi commented Oct 7, 2025

cherry-pick #8095 into gold

charlesh88 and others added 3 commits October 7, 2025 16:03
* Markup and CSS changes for expanded Activities in Time List
- Significant markup and CSS changes.
- Activities now use Plan colors.
- Greatly improved narrow space and wrapping.
- Added new global data uri's for status icons.
- Added new global `gear-spinner` animation for in-progress Activity status icon.
- Added new global `absCenter` mixin.
- Revised and greatly simplified execution status and time context labels.
- Revised, refined past/current/future styling and theme colors.
- Status icon coloring added to theme constants.
- Updated other themes constants for new approach to bg/fg/em.
- Smoke tested in Espresso and Snow themes.

* Remove unused imports

* Remove unused and commented out code

* Remove progress pie tests as that widget no longer exists

* lint fix

* remove tests for progress pie as it no longer exists

---------

Co-authored-by: Shefali <simplyrender@gmail.com>
Co-authored-by: David Tsay <3614296+davetsay@users.noreply.github.com>
* Markup and CSS changes for expanded Activities in Time List
- Significant markup and CSS changes.
- Activities now use Plan colors.
- Greatly improved narrow space and wrapping.
- Added new global data uri's for status icons.
- Added new global `gear-spinner` animation for in-progress Activity status icon.
- Added new global `absCenter` mixin.
- Revised and greatly simplified execution status and time context labels.
- Revised, refined past/current/future styling and theme colors.
- Status icon coloring added to theme constants.
- Updated other themes constants for new approach to bg/fg/em.
- Smoke tested in Espresso and Snow themes.

* Remove unused imports

* Remove unused and commented out code

* Remove progress pie tests as that widget no longer exists

* lint fix

* remove tests for progress pie as it no longer exists

---------

Co-authored-by: Shefali <simplyrender@gmail.com>
Co-authored-by: David Tsay <3614296+davetsay@users.noreply.github.com>
@shefalijoshi shefalijoshi requested a review from davetsay October 7, 2025 23:12
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

❌ Patch coverage is 5.00000% with 19 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (gold@87b2ea3). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/plugins/timelist/ExpandedViewItem.vue 5.00% 19 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             gold    #8177   +/-   ##
=======================================
  Coverage        ?   57.19%           
=======================================
  Files           ?      678           
  Lines           ?    27482           
  Branches        ?     2689           
=======================================
  Hits            ?    15717           
  Misses          ?    11424           
  Partials        ?      341           
Flag Coverage Δ
e2e-ci 62.83% <ø> (?)
e2e-full 23.59% <ø> (?)
unit 49.24% <5.00%> (?)
Files with missing lines Coverage Δ
src/plugins/timelist/TimelistComponent.vue 64.79% <ø> (ø)
src/plugins/timelist/ExpandedViewItem.vue 5.76% <5.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87b2ea3...3170e81. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@akhenry akhenry merged commit 1190429 into gold Oct 9, 2025
11 of 17 checks passed
@akhenry akhenry deleted the cherry-pick-expanded-timelist branch October 9, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants