-
Notifications
You must be signed in to change notification settings - Fork 49
FEATURE: Add CompletableFuture BTree insert/get API #1026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
a07510d to
91630d5
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
91630d5 to
310caa8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btree api PR์ ์ ์ฒด์ ์ผ๋ก ์๋์ ๊ฐ์ ์ค๋ช ๋ง๋ถ์ฌ ์ฃผ์ธ์
- as-is ์ํ์์์ ๋ฐํ๊ฐ / to-be ์ํ์์์ ๋ฐํ๊ฐ
- as-is ์ํ์์์ ์์ธ ์ ๋ฐํ ๊ฐ / to-be ์ํ์์์ ์์ธ ์ ๋ฐํ๊ฐ
์ ๋ถ๋ถ์ด ๋์ค์ ํด๋น ๊ธฐ๋ฅ ๋ฆด๋ฆฌ์ฆ ํ ๋, ์ด์ฐจํผ ์ฌ์ฉ์์๊ฒ๋ ๊ฐ์ด๋ ๋์ด์ผ ํ ๋ด์ฉ์
๋๋ค.
๋ฒ๊ฑฐ๋กญ๋๋ผ๋ ์ง๊ธ ๋ฏธ๋ฆฌ ์์ฑํ๋ค๊ณ ์๊ฐํ๊ณ ํด์ฃผ์๋ฉด ๊ฐ์ฌํ๊ฒ ์ต๋๋ค
310caa8 to
67103e8
Compare
|
@brido4125 |
67103e8 to
a4de747
Compare
a4de747 to
fd67320
Compare
fd67320 to
01134d3
Compare
|
@brido4125 @uhm0311 |
01134d3 to
eed5b94
Compare
c3673fa to
8c48d80
Compare
uhm0311
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์ง๋ฌธ์ ๋๋ค.
jhpark816
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๋ฆฌ๋ทฐ ์๋ฃ
src/main/java/net/spy/memcached/v2/vo/BTreeInsertAndGetTrimmed.java
Outdated
Show resolved
Hide resolved
1a60591 to
7ddf1a6
Compare
b5fbc22 to
b5b113f
Compare
uhm0311
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๋ฆฌ๋ทฐ์ ๋๋ค.
b5b113f to
a6c92cb
Compare
jhpark816
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์ผ๋ถ ๋ฆฌ๋ทฐ
| public static final class Builder { | ||
| private ElementFlagFilter eFlagFilter; | ||
| private int offset = 0; | ||
| private int count = 50; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default ๊ฐ 50์ ์ด๋ค ๊ธฐ์ค์ผ๋ก ์ค์ ํ ๊ฒ์ธ๊ฐ์?
bop get/mget/smget ์ฐ์ฐ๋ง๋ค ๋ฌ๋ผ์ง ๊ฒ ๊ฐ์๋ฐ์.
bop get์์๋ default๊ฐ 0์ด์ด์ผ ํ๊ณ ,
๊ทธ ์ธ๋ count ๊ฐ์ด ์ค์ ๋์ด์ผ ํ ๊ฒ ๊ฐ์ต๋๋ค.
๋ฐ๋ผ์, default ๊ฐ 0์ด ๋ง์ ๊ฒ ๊ฐ์ต๋๋ค.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bop get/mget/smget ์์ ๋ชจ๋ ์ค๋ฅ ์์ด ์ฌ์ฉ ๊ฐ๋ฅํ ์ต๋ ๊ฐ์ ์ค์ ํด๋ ๊ฒ ๋ฟ์
๋๋ค.
default ๊ฐ์ 0์ผ๋ก ๋๋ฉด mget ์์ ํญ์ 50์ผ๋ก ์ฌ์ ์ํด๋์ด์ผ ํ๊ธฐ ๋๋ฌธ์ ์ฌ์ฉํ ๋ ๋ถํธํ์ง ์์๊น ์ถ์๋๋ฐ,
0์ผ๋ก ๋๋๊ฒ ๋ ๋ซ๋ค๋ฉด ๋ณ๊ฒฝํ๊ฒ ์ต๋๋ค.
a6c92cb to
2fa92e5
Compare
|
@jhpark816 ๋ฆฌ๋ทฐ ๋ฐ์ํ์ต๋๋ค. resolveํ์ง ์์ ์ฝ๋ฉํธ์ ๋ํด์๋ ์๊ฒฌ ์ฃผ์๊ฑฐ๋ ์ผ๋จ resolve ์ํ๋ก ๋ณ๊ฒฝํด์ฃผ์๋ฉด ๋ฉ๋๋ค. |
2fa92e5 to
41521bd
Compare
|
@uhm0311 |
๐ Related Issue
โจ๏ธ What I did
๊ตฌํ ๊ด์ ํน์ด ์ฌํญ
Transcoder<Object>ํ์ ์ ๊ฐ์ ธ์Transcoder<T>ํ์ ์ผ๋ก ํ๋ณํํฉ๋๋ค.SMGet ๊ด๋ จ ์ฌํญ
SMGetResult#mergeSMGetResults์ ์ ๋ฉ์๋์ ๊ฐ๋ค์ ํฉ์น๋ ๋ก์ง์ ์์ํฉ๋๋ค.bkey -> btree item key์์ผ๋ก ์ ๋ ฌ๋ฉ๋๋ค. ๋ค๋ง ํ๋์ BKey๋ฅผ ์ ๋ ฅ๋ฐ๋ API์ ๊ฒฝ์ฐbtree item key๊ฐ ํญ์ ascending ์์ผ๋ก ์ ๋ ฌ๋ฉ๋๋ค.์๋ก ์ถ๊ฐ๋ VO ํด๋์ค๋ค๊ณผ ๊ฐ ๋ฉ์๋์ ์๋ฒ ์๋ต ๋ณ ๋ฐํ ๊ฐ์ New Interface ์ค๊ณ(Notion ๋ฌธ์)์ ์ ๋ฆฌ๋์ด ์์ต๋๋ค.
๊ฐ์ฅ ๊ธฐ๋ณธ์ ์ธ ๋ฉ์๋๋ค๋ง ์ถ๊ฐํ์๊ณ ,
bop update,bop incr๋ฑ์ API๋ ๋ค์ PR๋ก ์ถ๊ฐํ ์์ ์ ๋๋ค.