-
Notifications
You must be signed in to change notification settings - Fork 0
Hotbff #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
murvold
commented
Oct 20, 2025
- Bytter til Hotbff og fjerner det gamle oppsettet for server
- Legger til originale parametre for dekoratøren igjen etter støtte for dette kom ut
This reverts commit 8ea7a34.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the server implementation from a Node.js/TypeScript-based Express server to a Go-based Hotbff server. The migration removes all custom server infrastructure (authentication, routing, proxy, metrics) in favor of the Hotbff framework, which provides these capabilities out-of-the-box. Additionally, the decorator integration is updated to use the new parameter format that was recently supported.
Key changes:
- Replaces entire Node.js/Express server with Go-based Hotbff implementation
- Updates decorator integration to use new
paramsstructure - Adjusts deployment configuration for new server endpoints and framework
Reviewed Changes
Copilot reviewed 27 out of 34 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| server/main.go | New Go-based Hotbff server entry point with configuration for routing, decorator, and proxy |
| server/go.mod | Go module definition specifying Go version and Hotbff dependency |
| server/dev.sh | Development environment setup script for running the Go server locally |
| server/.gitignore | Ignores compiled Go binary |
| Dockerfile | Updated to use Go builder instead of Node.js for server compilation |
| client/vite.config.mts | Updates decorator integration to use new params structure |
| client/index.html | Changes template syntax for Go templating engine |
| docker-compose.yml | Updates port mapping and environment variables for new server |
| .nais/prod.yml, .nais/dev.yml, .nais/labs.yml | Updates health check paths, removes Prometheus metrics, adds nav-dekoratoren access policy |
| .github/workflows/deploy-dev.yml | Adds hotbff branch to deployment triggers |
| server/package.json, server/tsconfig.json, server/test/tsconfig.json, server/src/.mts, server/test/.ts, server/.prettierrc | Removes all Node.js/TypeScript server files |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.