Add general efisetjmp_arch.h #93
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmbr3
requested changes
Jan 1, 2026
Collaborator
gmbr3
left a comment
gmbr3
left a comment
There was a problem hiding this comment.
Thanks for this 😀 - it'll help for software which doesn't include the arch specific includedir
Changes needed:
- Rename commit to something more informational like "Add generic efisetjmp_arch.h"
- Signoff and GPG sign the commit e.g.
git commit --amend --signoff -S
Collaborator
|
Build broken |
Author
|
OK, the commit now has a verifed signature. I was spending some time figuring out on why on earth my commits are not being signed, but finally they are. Also, what exactly failed? |
gmbr3
requested changes
Jan 1, 2026
Collaborator
gmbr3
left a comment
gmbr3
left a comment
There was a problem hiding this comment.
Rebase branch if possible - merge commits are annoying
calmsacibis995
force-pushed
the
fix-include
branch
from
173aae9 to
20baf91
Compare
Author
|
OK, I rebased the branch on |
Author
|
I corrected a typo that causes the checks to fail on ia32. |
Author
|
I corrected another typo that causes riscv checks to fail. |
Author
|
I think now all checks are now going to pass. |
gmbr3
requested changes
Jan 2, 2026
Collaborator
gmbr3
left a comment
gmbr3
left a comment
There was a problem hiding this comment.
Rebase (fixup) to one commit
Signed-off-by: Stefanos Stefanidis <www.fe32gr23@gmail.com> Correct a typo. Correct another typo. Add check for 64-bit RISC-V platforms. Fix another typo. Add a common efisetjmp_arch.h
calmsacibis995
force-pushed
the
fix-include
branch
from
dbc35a7 to
a9803a8
Compare
Author
|
OK, I there is now only a single commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A header file needed by
efisetjmp.hwas created to fix an issue withefilib.h.