Skip to content

Conversation

@yt-topicus
Copy link
Contributor

Fixes #104

@yt-topicus
Copy link
Contributor Author

@neilime Would you have some time to take a look at the PR and provide feedback if necessary?

@neilime
Copy link
Owner

neilime commented May 1, 2025

@yt-topicus I want to give a chance at PHP_CS_FIXER to support PHP 8.4 before adding a workaround.
I'm waiting still 2 weeks.

@yt-topicus
Copy link
Contributor Author

@yt-topicus I want to give a chance at PHP_CS_FIXER to support PHP 8.4 before adding a workaround. I'm waiting still 2 weeks.

Okay that's understandable 👍

@neilime neilime force-pushed the feature/104-php84 branch from ecc9cf4 to 2ebc336 Compare May 1, 2025 08:54
@codecov
Copy link

codecov bot commented May 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.38%. Comparing base (2761c45) to head (9b61e4a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #105   +/-   ##
=========================================
  Coverage     95.38%   95.38%           
  Complexity      209      209           
=========================================
  Files            11       11           
  Lines           520      520           
=========================================
  Hits            496      496           
  Misses           24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@neilime neilime force-pushed the feature/104-php84 branch from 2ebc336 to 9b61e4a Compare May 13, 2025 11:27
@neilime neilime merged commit e7a6f86 into neilime:main May 13, 2025
6 checks passed
@neilime neilime changed the title Bump constraint to support PHP 8.4 feat: add support for PHP 8.4 May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support PHP 8.4

2 participants