Skip to content

Conversation

@maxiwheat
Copy link

No description provided.

Copy link

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, since chr(60.6) = chr(60)

@caugner
Copy link

caugner commented Feb 16, 2022

@neitanod Any chance to merge and release this fix for PHP 8.1? 😃

Copy link

@sailenicolas sailenicolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks. I'd forked this project, you can create a pr if you want

@DannyMeyer
Copy link

DannyMeyer commented Aug 9, 2022

@neitanod Can you please merge and tag this PR? It would help a lot :-)

In addition to this PR, the minimum PHP version has to be increased to PHP 7 in the composer.json. intdiv wasn't present in PHP 5

@Eye2iD
Copy link

Eye2iD commented Oct 11, 2022 via email

@Acksop
Copy link

Acksop commented Jun 25, 2024

$cc1 = (chr(intdiv(ord($c1), 64)) | "\xc0");
Deprecated: Implicit conversion from float 3.640625 to int loses precision ??
https://stackoverflow.com/questions/71534654/implicit-conversion-from-float-number-to-int-loses-precision

@Eye2iD
Copy link

Eye2iD commented Jun 25, 2024 via email

Copy link
Owner

@neitanod neitanod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use intdiv() for php 8.1 compatibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants