-
Notifications
You must be signed in to change notification settings - Fork 544
Use the latest pycolmap #536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
* Use pycolmap.Reconstruction instead of SceneManager * Use CameraModelId instead of string comparison
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I can review this--I'm not part of the gsplat team, so I don't know what they plan for on Colmap version compatibility. I've used this patch for my own project and it works well. Sorry :)
Co-authored-by: Rogério Gasi <rtgasi@gmail.com>
Hi @npu-chenlin . |
Thanks for your suggestion, but we have already corrected the parameter index in our code. Could it be that you are using an earlier commit?
|
Use pycolmap.Reconstruction instead of SceneManager
Use CameraModelId instead of string comparison