Skip to content

Conversation

npu-chenlin
Copy link

  • Use pycolmap.Reconstruction instead of SceneManager

  • Use CameraModelId instead of string comparison

* Use pycolmap.Reconstruction instead of SceneManager

* Use CameraModelId instead of string comparison
Copy link

@johnvanatta-plus johnvanatta-plus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I can review this--I'm not part of the gsplat team, so I don't know what they plan for on Colmap version compatibility. I've used this patch for my own project and it works well. Sorry :)

@MomokoMatsuo
Copy link

Hi @npu-chenlin .
Great PR I think but there is a bug in reading distortion parameters.
Please follow the issue: #794

@npu-chenlin
Copy link
Author

Hi @npu-chenlin . Great PR I think but there is a bug in reading distortion parameters. Please follow the issue: #794

Thanks for your suggestion, but we have already corrected the parameter index in our code. Could it be that you are using an earlier commit?

# SIMPLE_RADIAL:      f, cx, cy, k
if type_ == CameraModelId.SIMPLE_RADIAL:
    params = np.array([cam.params[3], 0.0, 0.0, 0.0], dtype=np.float32)
    camtype = "perspective"
# RADIAL:             f, cx, cy, k1, k2
elif type_ == CameraModelId.RADIAL:
    params = np.array([cam.params[3], cam.params[4], 0.0, 0.0], dtype=np.float32)
    camtype = "perspective"

umaaji298 added a commit to umaaji298/gsplat that referenced this pull request Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants