Skip to content

Conversation

mark-plukkido
Copy link

Hi,

I've created this patch to support source map resolution for Nest TypeScript applications. It is a somewhat simplistic solution as it does not read the source map tag in the compiled JS files. It assumes the source map file is right beside the compiled JS file. This is what nest start does by default.

Let me know if there are any issues with this PR, I'm happy to work on it.

@shekohex shekohex requested a review from bashleigh January 2, 2020 22:05
@mark-plukkido
Copy link
Author

I tried to raise code coverage to pass the tests by either writing .map files or using mock-fs. None of them seems to be working. This does not affect the actual code, just the tests. I'm open to suggestions as I've run out of ideas.

permanently so CI tests can hopefully execute
@mark-plukkido
Copy link
Author

I've added a static .map file to the src/__tests__ directory so the CI test completes, but it's clearly not the nicest solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant