19724 Add pagination metadata to GraphQL queries #20578
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthanson
changed the title
arthanson
requested review from
a team and
jeremystretch
and removed request for
a team
|
Holding on this until we've added GraphQL API v2 per #20603. Once that's done, this can be rebased and we'll make the necessary adaptations to move the metadata to the v2 API. |
jeremystretch
added
the
status: blocked
jeremystretch
removed
the
status: blocked
|
Following the change in #20603 (which introduced the v2 API), the GraphQL API now defaults to the original v1 format. Seems like it would be most prudent to refactor and duplicate the existing |
arthanson
changed the title
arthanson
changed the title
|
@jeremystretch ready for re-review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #19724
Adds new OffsetPaginated Generic to the v2 of the GraphQL API. For information on OffsetPaginated Generic see: https://strawberry.rocks/docs/django/guide/pagination. This returns metadata of the record counts and affects both the return of GraphQL queries as well as submission for paginated results. This PR updates the documentation on the new formats and puts in tests for the new v2 version of the queries.