- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 150
 
Validator::formatMessage: support dynamic error messages #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            jtojnar
  wants to merge
  1
  commit into
  nette:master
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
jtojnar:dynamic-error-message
  
      
      
   
  
    
  
  
  
 
  
      
    base: master
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    53ba399    to
    b789d86      
    Compare
  
    4876961    to
    b8d3a7c      
    Compare
  
    This is useful when you want to show user an informative error message, whose text depends on some external data that depends on the value of some other field. For example, my form allows user to choose a category of a team. Each category has a different limit for number of allowed members, which is specified in config.neon. I want to show the user the limit as part of the error message when she manages to exceed the limit.
b789d86    to
    78032f2      
    Compare
  
    41ff307    to
    f03a237      
    Compare
  
    341ed9a    to
    97e6400      
    Compare
  
    9d62255    to
    ec59537      
    Compare
  
    21f7326    to
    35f9b84      
    Compare
  
    dc0cb8f    to
    dd11397      
    Compare
  
    dd9d4ef    to
    458607d      
    Compare
  
    9c1d9cf    to
    12d238b      
    Compare
  
    49c38f3    to
    c6f98c1      
    Compare
  
    337f707    to
    2146e59      
    Compare
  
    94f43f0    to
    fe374c5      
    Compare
  
    cb844f0    to
    1d8a434      
    Compare
  
    479185b    to
    8da5796      
    Compare
  
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
This is useful when you want to show user an informative error message, whose text depends on some external data that depends on the value of some other field.
For example, my form allows user to choose a category of a team. Each category has a different limit for number of allowed members, which is specified in config.neon. I want to show the user the limit as part of the error message when she manages to exceed the limit.