Features/add denodo service #299
Closed
+42
−5,006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: docs/SERVICES.md backend/src/server/services/definitions/denodo.rs
modified: docs/SERVICES.md
backend/src/server/services/definitions/denodo.rs
modified: backend/src/server/services/definitions/mod.rs
new file: backend/src/server/services/definitions/denodo.rs
modified: backend/src/server/services/definitions/mod.rs
modified: docs/SERVICES.md
new file: backend/src/server/services/definitions/denodo.rs
modified: backend/src/server/services/definitions/mod.rs
Collaborator
|
@Gsyltc can you re-run npm install locally, and re-commit that file? You may need to git pull the latest changes from this remote branch first. I was confused by a change I saw in package-lock.json and tried to remove the file from the commit, but ended up committing a deletion of the file which is making it hard to merge this PR. git checkout features/add_denodo_service should do the trick! |
Author
|
Hello Maya |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Add definitions service for Denodo
Official Website: https://www.denodo.com/fr
Default Ports: (Principals)
9990: Virtual Data Port
9996: ODBC Port
9090: WebUI Port (Denodo Studio)
9099: Web container Serveur Port
Icon Source: Dashboard Icons
Testing:
Compiles successfully
Tested against real instance (describe setup below)
Unable to test (explain why below)
Testing Details:
Unable to test (Container step).
Cause : Right on directory (nfs)
Format: passed
Linter : passed