Add multiprocessing optional dependency #72
Merged
+9
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
=======================================
Coverage 77.15% 77.15%
=======================================
Files 3 3
Lines 197 197
=======================================
Hits 152 152
Misses 45 45 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
adamltyson
requested changes
Aug 18, 2025
There was a problem hiding this comment.
Hi @STORM-codess, thanks for this. I've left a couple of small comments.
Co-authored-by: Adam Tyson <code@adamltyson.com>
adamltyson
requested changes
Aug 19, 2025
There was a problem hiding this comment.
Thanks. I made one tiny suggestion so that the wording is consistent with the readme, and I don't think most users necessarily know what an "extra" means in this context.
Other than this, I think this is ready to merge. Thanks @STORM-codess!
Co-authored-by: Adam Tyson <code@adamltyson.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
multiprocessing-loggingas an optional dependency inpyproject.toml.This allows users who want to enable logging across multiple processes to install the package with:
pip install fancylog [multiprocessing]